ESP32/ESP32-S3 adc calibration #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
May 16, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
May 16, 2023
thebentern
approved these changes
May 16, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of commits seeks to put an end to the question of battery voltage accuracy on any esp32 based platform.
I have cribbed code from paxcounter since they seem to have an excellent handle on many of the boards we've found problematic.
This iteration makes use of the esp-idf framwork's legacy adc calibration driver, but it works well on my TTGO v2.1-1.6 boards when they aren't plugged in to USB. Since 2018 all of Espressif's esp32 chips get Vref efuse calibration from the factory. This represents a best-effort attempt to provide more accurate voltage reads without end user tinkering.