Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix t-beam-s3-core display not working #2520

Merged
merged 2 commits into from
May 27, 2023
Merged

Fix t-beam-s3-core display not working #2520

merged 2 commits into from
May 27, 2023

Conversation

lewisxhe
Copy link
Contributor

@lewisxhe lewisxhe commented May 27, 2023

See #2519

https://meshtastic.discourse.group/t/new-lilygo-t-beam-supreme-product/7474
The conditional macro cannot recognize the enumeration variable, change it to a conditional statement to determine the hardware manufacturer model.

When the OLED power is not turned on, scanning the I2C port will cause the application to be stuck, because the I2C bus is not normal. It cannot scan to the device correctly.

@lewisxhe lewisxhe changed the title Fix t-beam-s3-core display not working https://github.com/meshtastic/firmware/issues/2519 Fix t-beam-s3-core display not working May 27, 2023
@github-actions
Copy link
Contributor

🤖 Pull request artifacts

file commit
pr2520-firmware-2.1.13.78af6e2.zip 78af6e2

thebentern added a commit to meshtastic/artifacts that referenced this pull request May 27, 2023
@geeksville
Copy link
Member

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/new-lilygo-t-beam-supreme-product/7474/28

@Tom9876
Copy link

Tom9876 commented May 27, 2023

Thank you very much for the quick fix. Display now working as expected.

`INFO | ??:??:?? 2 Scanning for i2c devices...

DEBUG | ??:??:?? 2 Scanning for i2c devices on port 2
DEBUG | ??:??:?? 3 I2C device found at address 0x34
INFO | ??:??:?? 3 axp192/axp2101 PMU found
DEBUG | ??:??:?? 3 I2C device found at address 0x51
INFO | ??:??:?? 3 PCF8563 RTC found
DEBUG | ??:??:?? 4 Scanning for i2c devices on port 1
DEBUG | ??:??:?? 4 I2C device found at address 0x1c
INFO | ??:??:?? 4 QMC6310 Highrate 3-Axis magnetic sensor found
DEBUG | ??:??:?? 5 I2C device found at address 0x3c
INFO | ??:??:?? 5 sh1106 display found
DEBUG | ??:??:?? 5 0x0 subtype probed in 1 tries
DEBUG | ??:??:?? 5 I2C device found at address 0x77
DEBUG | ??:??:?? 5 Wire.available() = 0
INFO | ??:??:?? 5 BMP-280 sensor found at address 0x77
INFO | ??:??:?? 6 5 I2C devices found`

Also the BMP-280 was detected. But - after activating telemetry in the settings - still no environmental data available. Any specific settings required?

@caveman99
Copy link
Sponsor Member

working for me too - i'm gonna fix the linter errors and accept the PR.

@caveman99 caveman99 merged commit fbcd674 into meshtastic:master May 27, 2023
44 of 45 checks passed
@geeksville
Copy link
Member

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/new-lilygo-t-beam-supreme-product/7474/33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants