Cancel rebroadcast in Tx queue upon receiving another rebroadcast #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… there was one in Tx queue already
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jun 1, 2023
thebentern
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we receive a rebroadcast for an already received packet (
wasSeenRecentlyis true), cancel the rebroadcast that’s currently in the Tx queue (if there was one).This will reduce channel utilization due to duplicates and therefore the chance of collisions, but the downside is that we lose some redundancy that we apparently had (not by design).
One broadcast from node 0 using current master in the interactive simulator:
With this PR:
I will ask burr in Discord (who found it) to test this.
(Also updated the platform-native reference to let portduino build again.)