Fix static ethernet config #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micheljung
force-pushed
the
fix/2543-static-ip
branch
from
8d53f3d
to
c884698
Compare
|
Seems like there are more issues, I'll report back when I successfully tested it. |
thebentern
approved these changes
Jun 6, 2023
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jun 6, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jun 6, 2023
micheljung
force-pushed
the
fix/2543-static-ip
branch
from
c884698
to
b0e93b9
Compare
micheljung
force-pushed
the
fix/2543-static-ip
branch
from
b0e93b9
to
bf5d6de
Compare
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jun 6, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jun 6, 2023
micheljung
force-pushed
the
fix/2543-static-ip
branch
from
bf5d6de
to
8946f6a
Compare
With static ethernet config, `status` stayed `0` which let the function return without setting `ethEvent`. Therefore, `reconnectETH` was never called and network services were never started. Also, the RAK4631 uses little endian, which is why the IP addresses need to be converted before setting them. Fixes meshtastic#2543
micheljung
force-pushed
the
fix/2543-static-ip
branch
from
8946f6a
to
3615639
Compare
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jun 6, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jun 6, 2023
thebentern
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With static ethernet config,
statusstayed0which let the function return without settingethEvent. Therefore,reconnectETHwas never called and network services were never started.Fixes #2543