RAK14001 LED - Turn on to 50% at boot #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jun 25, 2023
|
I'll also note that I live tested on a RAK 4631 |
charminULTRA
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the RAK14001 to turn on to a static 50% white upon boot, and creates a central location (RAKled.h) for defining "rgb".
I could use help in one aspect of this - I don't know C++ fundamentals, so I suspect the organization of code between this and the ExternalNotificationModule could be better organized. I'm not 100% sure if I used best practices, but I tried moving the declaration of "rgb" into the RAKled.h file to give it a more centralized location rather than the Module's file.
In the future, I would like to add the ability to control the LED levels/colors/cycles via the CLI and apps.