Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPS: Implement Power Management, Refactor Code and Fix GSA Message Configuration for U-Blox hardware #2606

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

D4rk4
Copy link
Contributor

@D4rk4 D4rk4 commented Jul 11, 2023

In this merge request, I introduce several enhancements and fixes to improve the overall functionality and power efficiency of our GPS module. Here's a summary of the changes made:

  1. Power Management: I have integrated power management support using the UBX-CFG-PMS message. This allows us to configure the GPS module's power consumption according to our needs. For now, it is set to "Aggressive with 1 Hz: The module operates in a power saving mode with a 1 Hz update rate."

  2. Code Refactoring: I've cleaned up and improved the readability of our existing code base. This includes better structuring the code, adding descriptive comments, and optimizing existing functions for better performance.

  3. Fix GSA Message Configuration: I've fixed an issue in the GSA message configuration that was causing unexpected behavior. The correct UBX message format and parameters are now used.

These changes contribute to a more power-efficient, stable, and reliable operation of the GPS module, ensuring optimal functionality while minimizing power consumption. The revised code is also more maintainable and easier to understand. I request the team to review the proposed changes and provide feedback.

@D4rk4 D4rk4 changed the title GPS: Implement Power Management, Refactor Code and Fix GSA Message Configuration GPS: Implement Power Management, Refactor Code and Fix GSA Message Configuration for U-Blox hardware Jul 11, 2023
@github-actions
Copy link
Contributor

🤖 Pull request artifacts

file commit
pr2606-firmware-2.1.19.818af13.zip 818af13

thebentern added a commit to meshtastic/artifacts that referenced this pull request Jul 11, 2023
@thebentern thebentern merged commit aa0b56e into meshtastic:master Jul 13, 2023
47 checks passed
@geeksville
Copy link
Member

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/neo-6m-power-save-mode/7869/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants