-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hydra specific target to define GPS EN pin and limit tx power #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jul 12, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jul 14, 2023
thebentern
changed the title
Use DIO2 bridged to TXEN and remove TX/RXEN pin switching altogether
Add Hydra specific target to define GPS EN pin and limit tx power
Jul 18, 2023
kokroo
reviewed
Sep 5, 2023
#define SX126X_BUSY LORA_DIO2 | ||
#define SX126X_RESET LORA_RESET | ||
|
||
// Set lora.tx_power to 13 for Hydra or other E22 900M30S target due to PA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thebentern Why is the power for Ebyte chips limited to 22 here, even when they can go to 30? In the comment, it mentions it's because of the PA, but I am not sure how that's affecting this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.