Check Position Request for Primary Channel

[jp-bennett]

Prevents leaking location data to secondary channels.

[GUVWAF]

I now remember that there is a way to ignore requests, which seems like a better approach than overriding sendResponse with largely duplicated logic and exposing currentReply to all modules. This should be as simple as doing the if-condition within PositionModule's allocReply, set ignoreRequest to true and return NULL (see https://github.com/meshtastic/firmware/blob/master/src/modules/NodeInfoModule.cpp#L62). Can you do it in that way?

[jp-bennett]

@GUVWAF That was how I wanted to accomplish this, but allocReply doesn't have access to the incoming request packet.
One possible approach does come to mind, where we add a data field to the postitioModule class, set it in the handleRecieveProtobuf function, and access it in allocReply. I'm not 100% sure that'll work, but it is a cleaner approach. I'll give it a shot later today.

[GUVWAF]

Ah, you're right and you mentioned that already, sorry. Your other approach sounds good and would be cleaner indeed.

[GUVWAF]

You could set ignoreRequest to true in handleReceivedProtobuf and return NULL in allocReply if this is the case.

[jp-bennett]

@GUVWAF Seems to work as expected. Agreed, this is a much better approach.

[GUVWAF]

@jp-bennett Great! Looks good to me.