Fix for Pi Pico hang

[jp-bennett]

The pico startup code was leaving _serial_gps set to null, but then failing to properly catch that state and short-circuit GPS probing. Fix by disabling the GPS thread when null.

[rcarteraz]

Still hangs

WARNING file:mesh_interface.py _sendToRadio line:680 Not sending packet because protocol use is disabled by noProto
INFO  | ??:??:?? 0 

//\ E S H T /\ S T / C


DEBUG | ??:??:?? 0 Filesystem files:
DEBUG | ??:??:?? 0  channels.proto (53 Bytes)
lfs_file_close: fd=0x20012e14
DEBUG | ??:??:?? 0  db.proto (112 Bytes)
lfs_file_close: fd=0x20012e14
DEBUG | ??:??:?? 0 Using analog input 26 for battery level
INFO  | ??:??:?? 0 Scanning for i2c devices...
DEBUG | ??:??:?? 0 Scanning for i2c devices on port 1
INFO  | ??:??:?? 0 No I2C devices found
DEBUG | ??:??:?? 0 acc_info = 0
INFO  | ??:??:?? 0 Meshtastic hwvendor=47, swver=2.2.8.8f9d3352
INFO  | ??:??:?? 0 Initializing NodeDB
INFO  | ??:??:?? 0 Loading /prefs/db.proto
lfs_file_close: fd=0x20012bb4
INFO  | ??:??:?? 0 Loaded saved devicestate version 22
LittleFSDirImpl::openFile: rc=-2 fd=0x20012bb4 path=`/prefs/config.proto` openMode=0 accessMode=1 err=-2
INFO  | ??:??:?? 0 No /prefs/config.proto preferences found
INFO  | ??:??:?? 0 Installing default LocalConfig
INFO  | ??:??:?? 0 Setting default channel and radio preferences!
DEBUG | ??:??:?? 0 Expanding short PSK #1
INFO  | ??:??:?? 0 Wanted region 0, using UNSET
LittleFSDirImpl::openFile: rc=-2 fd=0x20012bb4 path=`/prefs/module.proto` openMode=0 accessMode=1 err=-2
INFO  | ??:??:?? 0 No /prefs/module.proto preferences found
INFO  | ??:??:?? 0 Installing default ModuleConfig
INFO  | ??:??:?? 0 Loading /prefs/channels.proto
lfs_file_close: fd=0x20012bb4
INFO  | ??:??:?? 0 Loaded saved channelFile version 22
LittleFSDirImpl::openFile: rc=-2 fd=0x20012bb4 path=`/oem/oem.proto` openMode=0 accessMode=1 err=-2
INFO  | ??:??:?? 0 No /oem/oem.proto preferences found
DEBUG | ??:??:?? 0 cleanupMeshDB purged 0 entries
DEBUG | ??:??:?? 0 Expanding short PSK #1
INFO  | ??:??:?? 0 Wanted region 0, using UNSET
DEBUG | ??:??:?? 0 region=0, NODENUM=0x77b4323, dbsize=1
DEBUG | ??:??:?? 0 Read RTC time as 0
DEBUG | ??:??:?? 0 WANT GPS=1

[jp-bennett]

Half a fix. Hang on.

[github-actions]

🤖 Pull request artifacts

file	commit
pr2817-firmware-2.2.8.8f9d335.zip	8f9d335

[rcarteraz]

Success! 🥳 At least on the Pico. Let me check the RAK11300 now.

[rcarteraz]

Success x2! RAK11310 is booting also. 🥳 Great work @jp-bennett

[NickDolfin]

2.2.8 does not work on the rp2040 pico

[jp-bennett]

2.2.8 does not work on the rp2040 pico

The first generated .zip does not have the second half of the fix in it.

[jp-bennett]

@NickDolfin Can you try with the image generated here: https://github.com/meshtastic/firmware/actions/runs/6255294648#artifacts

[NickDolfin]

@jp-bennett Yes, you are right. I was to fast and downloaded the wrong one.

Now 2.2.8 is working.

Many thanks for the fast fix.