Move to portduino GPIO, adding user button support #2966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp-bennett
force-pushed
the
portduino-gpio
branch
from
620db0e
to
e48a9d5
Compare
jp-bennett
force-pushed
the
portduino-gpio
branch
from
e2ab868
to
b993122
Compare
jp-bennett
force-pushed
the
portduino-gpio
branch
from
30a8979
to
a45ca83
Compare
caveman99
reviewed
Nov 28, 2023
jp-bennett
force-pushed
the
portduino-gpio
branch
from
89ebbf5
to
03841f3
Compare
mverch67
reviewed
Nov 29, 2023
jp-bennett
force-pushed
the
portduino-gpio
branch
from
0a23cd0
to
f5587a4
Compare
mverch67
reviewed
Dec 12, 2023
| @@ -45,8 +48,14 @@ class ButtonThread : public concurrency::OSThread | |||
| // callback returns the period for the next callback invocation (or 0 if we should no longer be called) | |||
| ButtonThread() : OSThread("Button") | |||
| { | |||
| #ifdef BUTTON_PIN | |||
| #if defined(ARCH_RASPBERRY_PI) || defined(BUTTON_PIN) | |||
There was a problem hiding this comment.
This line looks superfluous, as both conditions are also checked below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves away from using pigpio for hardware support, getting us partway to being able to do away with a raspbian-specific variant. It also adds support for general GPIO like a user button.
Depends on meshtastic/framework-portduino#8