Pico W: Initial Wi-Fi support #2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GUVWAF
commented
Dec 2, 2023
| @@ -44,6 +47,61 @@ Syslog syslog(syslogClient); | |||
|
|
|||
| Periodic *wifiReconnect; | |||
|
|
|||
| static void onNetworkConnected() | |||
There was a problem hiding this comment.
Only moved this up here such that it is defined before usage on line 155.
Including it in the header file lead to errors.
GUVWAF
commented
Dec 2, 2023
| WiFi.disconnect(true); | ||
| WiFi.mode(WIFI_MODE_NULL); | ||
| #endif | ||
| WiFi.mode(WIFI_OFF); |
There was a problem hiding this comment.
Same as WIFI_MODE_NULL, but that's only defined for ESP32 (https://github.com/espressif/arduino-esp32/blob/master/libraries/WiFi/src/WiFiType.h#L32). Same holds for WIFI_MODE_STA vs WIFI_STA.
thebentern
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the Wi-Fi capability for the Pico W. Tested with MNMC, Android app and MQTT. Probably needs further tuning for reconnects etc.
Had to move some calls for the Wi-Fi stack that affect ESP32 as well, but I confirmed it to still be working on a T-Beam.