-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LTO discharge curve #3385
Fix LTO discharge curve #3385
Conversation
Maybe @Gabrielerusso can also give some feedback. As the original implementation is from him in #3216. I think the LTO curve was from @code8buster. |
I've also removed that comment block as all that information is in the define section below and no value is added by those comments from my pov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are not code of line and aren't put there randomly, for example there are three different curve for LiIon to chose from, and are there for reference for who wants to edit them to their custom usage.
Never took a look on what the LTO curve was, the other one I took them from BMS projects I was working so should be correct. |
How about I add those as individual configurations instead so that someone who wants to use them can directly configure for them? |
On second thought - this is probably too many options. @thebentern this should be fine to merge. |
* Fix LTO discharge curve * Remove duplicate info
Been testing LTO cells recently and noticed that the SoC values didn't make much sense.
Upon a closer look the values for the discharge curve are far off from what a typical LTO discharge curve looks like. Here I put in the current curve (red dots) to visualise this for myself:
This PR changes the curve to the values from this graph (1C) which in turn result in reasonable SoC values.
I did a cursory check on the other chemistries and they don't seem to suffer the same issue. So I guess some wrong discharge curve was used to deduct those values from maybe?