Check AQ_SET_PIN instead of EINK dependency #3387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caveman99
reviewed
Mar 12, 2024
|
Yes it is - but this should be clear for the ones using the eInk stuff in their configs as they have that pin assigned there. Otherwise we have tons of such checks for possible collisions in the code at some point. |
wnagele
force-pushed
the
check_aq_set_pin
branch
from
a7a4c1e
to
707388b
Compare
wnagele
added a commit
to wnagele/meshtastic-firmware
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should really check if the
AQ_SET_PINis defined here instead of depending on some other configuration element that has nothing directly to do with it. Checked against current RAK4630 based configs and should not break anything.