Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap backlight toggle and touch button #3560

Merged
merged 9 commits into from
Apr 6, 2024

Conversation

todd-herbert
Copy link
Contributor

@todd-herbert todd-herbert commented Apr 6, 2024

Addresses #3533

  • Ensure E-Ink display updates after "adhoc ping" or "toggle GPS"

  • Touch button wakes screen, disables screensaver (Includes TFT / OLED. Should narrow scope?)

  • Re-map buttons for T-Echo

      Send Adhoc Ping Toggle Backlight Exit stateDARK Force display update
    Previous Double Press (user button) Double Press (user button) -- Press (touch button)
    New Double Press (user button) Hold (touch button)
    + Double Press (user button)
    Press (touch button) Press (touch button)

    Intent is to separate "adhoc ping" and "toggle backlight" behaviors.


I vaguely remember reading a comment that T-Echo touch has a hardware issue, where LoRa TX consistently triggers the touch button. I did not observe any cases of this during testing, but if would be good to hear from anyone who has more information.

@b8b8
Copy link

b8b8 commented Apr 6, 2024

@todd-herbert Can we exclude the touch button completely please. the alternate cases i design for the t-echo are not compatible with it and ive pealed it off completely since all it did before was refresh the screen. Needing the touch button over the regular user buttons severely limits future designs. Can i ask we add 4x user button push for the t-echo light. The change you are proposing would render the light with alternate cases useless.

@todd-herbert todd-herbert marked this pull request as draft April 6, 2024 02:24
@todd-herbert
Copy link
Contributor Author

todd-herbert commented Apr 6, 2024

@b8b8 I wasn't aware that there was any sort of customization going like that going on. I certainly don't want to break existing set-ups.

I do think there is value in making use of the touch button, but I will see if 4x user button presses is a viable alternative. It's clear that some solution has to be implemented which doesn't require use of the touch button.

I will also look into using the "Wake screen on tap or motion" user-setting to entirely disable touch button functionality.

@b8b8
Copy link

b8b8 commented Apr 6, 2024

@todd-herbert great, thank you for understanding. The main issue is of course the backlight is pretty much exclusive to the t-echo and so is the touch button.

https://www.thingiverse.com/thing:5028720
here is one of my cases. i have another one that is different but has the same restriction on touch button use.

https://www.printables.com/model/302924-meshtastic-t-echo-compact-case
here is someone else's which also doesnt reuse the touch button which would have the same restriction.

@todd-herbert todd-herbert changed the title T-Echo Buttons Remap backlight toggle and touch button Apr 6, 2024
@todd-herbert
Copy link
Contributor Author

todd-herbert commented Apr 6, 2024

  Send Adhoc Ping Toggle Backlight Exit stateDARK Force display update
Previous Double Press (user button) Double Press (user button) -- Press (touch button)
Initial Suggestion Double Press (user button) Hold (touch button)
+ Double Press (user button)
Press (touch button) Press (touch button)
Revised Double Press (user button) 4x Press (user button) Press* (touch button) Press* (touch button)

* only if user sets "Wake screen on tap or motion"

Proposed behavior affects any devices which have an E-Ink backlight, and any devices with a touch button. Touch function is disabled by default, enabled with "Wake screen on tap or motion" option in display settings.

@todd-herbert todd-herbert marked this pull request as ready for review April 6, 2024 06:06
@thebentern thebentern merged commit 5b5f9c6 into meshtastic:master Apr 6, 2024
69 checks passed
@todd-herbert todd-herbert deleted the techo-button branch April 6, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants