Fix T-Beam S3 USB CLI #3736 #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope this finally fixes any issues around USB Serial while allowing to flash new FW without having to put the device in download mode first. Apologies for the issues this has been causing in the meantime. |
caveman99
approved these changes
May 2, 2024
caveman99
force-pushed
the
fix/3736-usb-cli-not-working
branch
from
36e6708
to
0f67562
Compare
|
This probably introduces a new issue: the device cannot work without serial connection... |
|
It does work without serial, I've tested that. The bug that causes serial to block has been fixed in the espressif arduino framework |
thebentern
added a commit
that referenced
this pull request
May 6, 2024
This reverts commit 7140010.
thebentern
added a commit
that referenced
this pull request
May 6, 2024
tavdog
pushed a commit
to tavdog/meshtastic-firmware
that referenced
this pull request
May 10, 2024
…tastic#3764)" (meshtastic#3809) This reverts commit 7140010.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3736
It seems that we do need ARDUINO_USB_CDC_ON_BOOT=1 after all in order for the CLI to work with the ESP32-S3. Otherwise I cannot get the S3 to read from USB Serial.
Issue #3650 that can cause the S3 to block on boot when no Serial is connected (and is triggered by ARDUINO_USB_CDC_ON_BOOT=1 in combination with ARDUINO_USB_MODE=1) has recently been fixed in arduino-esp32 @ 2.0.15 . I've confirmed that using platform_packages = framework-arduinoespressif32 @ https://github.com/espressif/arduino-esp32.git#2.0.15