Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send fixed position to mesh after setting it #3803

Merged
merged 1 commit into from
May 6, 2024
Merged

Send fixed position to mesh after setting it #3803

merged 1 commit into from
May 6, 2024

Conversation

thebentern
Copy link
Contributor

Closes #3783

garthvh
garthvh approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@garthvh garthvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly, I think this will offer the feedback people want.

@thebentern thebentern merged commit 0d57d29 into master May 6, 2024
71 checks passed
@thebentern thebentern deleted the send-fixed-position branch May 6, 2024 19:51
@ndoo
Copy link
Contributor

ndoo commented May 8, 2024

Is this code path possibly making the gps.enable from my earlier PR #3758 redundant or is it touching some other state enabling GPS doesn't?

tavdog pushed a commit to tavdog/meshtastic-firmware that referenced this pull request May 10, 2024
@thebentern @tavdog
Send fixed position to mesh after setting it (meshtastic#3803)
c216901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garthvh garthvh garthvh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Broadcast newly set fixed position immediately
3 participants
@thebentern @ndoo @garthvh