Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added AHTx0 sensor #3977

Merged
merged 11 commits into from
May 31, 2024
Merged

added AHTx0 sensor #3977

merged 11 commits into from
May 31, 2024

Conversation

fzellini
Copy link
Contributor

Hi, I have added the AHT10 sensor to the project, so, with inexpensive modules containing bmp280&AHT20 you have pressure, temp & humidity.

aht10

@CLAassistant
Copy link

CLAassistant commented May 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

caveman99
caveman99 requested changes May 27, 2024
View reviewed changes
platformio.ini Outdated Show resolved Hide resolved
src/configuration.h Show resolved Hide resolved
src/detect/ScanI2CTwoWire.cpp Show resolved Hide resolved
src/mesh/generated/meshtastic/telemetry.pb.h Outdated Show resolved Hide resolved
src/modules/Telemetry/Sensor/AHT10.cpp Show resolved Hide resolved
@caveman99
Copy link
Sponsor Member

You can add the sensor definiton here: https://github.com/meshtastic/protobufs/blob/5f78a06c0fe5d0bd99c2fe206165212bdce89da0/meshtastic/telemetry.proto#L347

@fzellini
Copy link
Contributor Author

fzellini commented May 28, 2024 •
edited
Loading

If BMP280+AHT20 detected, grab only humidity from AHT20...
....
DEBUG | ??:??:?? 12 [EnvironmentTelemetryModule] BMP280Sensor::getMetrics
INFO | ??:??:?? 12 [EnvironmentTelemetryModule] AHTX0+BMP280 module detected: using temp from BMP280 and humy from AHTX0
.....

@fzellini fzellini requested a review from caveman99 May 29, 2024 17:43
@fzellini
Copy link
Contributor Author

You can add the sensor definiton here: https://github.com/meshtastic/protobufs/blob/5f78a06c0fe5d0bd99c2fe206165212bdce89da0/meshtastic/telemetry.proto#L347

I have added sensor definition in my cloned repository

@thebentern
Copy link
Contributor

Please revert changes to the gitignore and gitmodules files.

@fzellini
Copy link
Contributor Author

Please revert changes to the gitignore and gitmodules files.

Done

alexander-smyslov
alexander-smyslov reviewed May 31, 2024
View reviewed changes
.gitignore Outdated
# !.vscode/settings.json
# !.vscode/tasks.json
# !.vscode/extensions.json
# *.code-workspace
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert

alexander-smyslov
alexander-smyslov reviewed May 31, 2024
View reviewed changes
.gitmodules Outdated
@@ -1,3 +1,3 @@
[submodule "protobufs"]
path = protobufs
url = https://github.com/meshtastic/protobufs.git
url = https://github.com/fzellini/meshtastic-protobufs
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert back

@fzellini
Copy link
Contributor Author

fzellini commented May 31, 2024 via email

@thebentern
Copy link
Contributor

.gitignore changes are still present. Please revert it

@fzellini
Copy link
Contributor Author

fzellini commented May 31, 2024 via email

@thebentern thebentern merged commit eddda3c into meshtastic:master May 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-smyslov alexander-smyslov alexander-smyslov left review comments

@caveman99 caveman99 Awaiting requested review from caveman99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fzellini @CLAassistant @caveman99 @thebentern @alexander-smyslov