Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-Ink screensaver validates short name #4115

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

todd-herbert
Copy link
Contributor

@todd-herbert todd-herbert commented Jun 15, 2024

Adds a function to Screen.cpp which checks if the OLED library is able to render all characters in a string.
Using this function, the E-Ink screensaver may decide not to draw the device's short name.

This new haveGlyphs function may be relevant for #4109 (comment)

With short name wp1
normal E-ink screensaver

With short name Pk墨, or 馃摐
noGlyphs

@thebentern thebentern merged commit 96be051 into meshtastic:master Jun 15, 2024
87 checks passed
@caveman99
Copy link
Sponsor Member

@todd-herbert this is causing a warning on non eink display compiles, casue the function is not used anywhere else. Wanna pull it into the e-ink conditional or are you planning to use it in other places as well?

@todd-herbert
Copy link
Contributor Author

@todd-herbert this is causing a warning on non eink display compiles, casue the function is not used anywhere else. Wanna pull it into the e-ink conditional or are you planning to use it in other places as well?

No plans elsewhere, sorry I didn't get to this in time. I'll make sure it gets moved inside that conditional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants