SX1268 module support and base class for SX126x module family #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radiolib sync upstream
Otherwise, we get critical error 3 with result code -12 (ERR_INVALID_FREQUENCY): The supplied frequency value is invalid for this module.
The `RadioInterface::freq` member was encapsulated with the `RadioInterface::getFreq()` function, which could be overridden in child classes for some LoRa-modules.
The frequency could be overridden in `RadioInterface::getFreq()` for some modules.
|
AWESOME! |
|
This pull request has been mentioned on Meshtastic. There might be relevant details there: https://meshtastic.discourse.group/t/sx1268-modules-are-not-yet-supported/3659/10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USE_SX1268andSX126X_[CS|DIO1|RESET|BUSY|etc.]pinouts to enable it.SX126xInterfacefor SX126x modules with common realization. Child modules specifies LoRa adapter from RadioLib in template, e.g.class SX1262Interface : public SX126xInterface<SX1262>.RadioInterface::freqmember was encapsulated with theRadioInterface::getFreq()function, which could be overridden in child classes for some LoRa-modules.Class diagram for these changes (view in mermaid editor):
