Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#927 add SSL notification at boot #935

Merged
merged 3 commits into from
Nov 29, 2021
Merged

#927 add SSL notification at boot #935

merged 3 commits into from
Nov 29, 2021

Conversation

rxt1077
Copy link
Contributor

@rxt1077 rxt1077 commented Nov 26, 2021

Resolves #927 by creating a screen that says "Creating SSL Certificate, Please wait..." at boot.

@sachaw
Copy link
Member

sachaw commented Nov 26, 2021

Just confirming, is this also displayed when generating an SSL cert whilst the device is on (not during boot)

@rxt1077
Copy link
Contributor Author

rxt1077 commented Nov 26, 2021 via email

@mc-hamster
Copy link
Member

Just confirming, is this also displayed when generating an SSL cert whilst the device is on (not during boot)

I’m not aware of other ssl generation other than the one time at boot.

@sachaw
Copy link
Member

sachaw commented Nov 27, 2021

May be something else then, I know at-least on more recent versions of the firmware, when I set the WiFi details after being flashed the device freezes as it appears to be generating a cert (as the console states). then comes good once it's done. The traditional behavior of generating one at startup is what I used to get. I'll take a look if this commit works for me.

@rxt1077
Copy link
Contributor Author

rxt1077 commented Nov 27, 2021 via email

@mc-hamster mc-hamster merged commit 757de54 into meshtastic:master Nov 29, 2021
@geeksville
Copy link
Member

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/meshtastic-device-1-2-48-alpha/4359/1

@mc-hamster
Copy link
Member

@rxt1077 Your change is now live. Thanks!

@geeksville
Copy link
Member

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/meshtastic-device-1-2-49-5354c49-alpha/4502/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When generating SSL certs, display "Please wait..." on the screen.
4 participants