Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic screen carousel behavior implementation (auto_screen_carousel_secs user preference) #937

Merged
merged 6 commits into from
Nov 29, 2021

Conversation

thebentern
Copy link
Contributor

This is the simplest MVP version possible. I've done some initial testing and it seems to behave well overall. It also respects static frames like the bluetooth pin from what I can tell.
@mc-hamster, picking up from our discussion in the discord, I was way over-complicating things... After digging a bit more, it turns out we can accomplish everything within Screen.cpp with just a few strategically placed lines of code.

@crossan007
Copy link
Contributor

Nice!!

If you want some more inspiration; I have a semi-abandoned branch that makes the dots "bounce" when there are message notifications, and makes double-pressing the button open either the currently notifying frame, or go to the first frame if there are no notifications: https://github.com/meshtastic/Meshtastic-device/compare/master...crossan007:adjust_frame_notifications?expand=1

@thebentern
Copy link
Contributor Author

Nice!!

If you want some more inspiration; I have a semi-abandoned branch that makes the dots "bounce" when there are message notifications, and makes double-pressing the button open either the currently notifying frame, or go to the first frame if there are no notifications: https://github.com/meshtastic/Meshtastic-device/compare/master...crossan007:adjust_frame_notifications?expand=1

Thanks, Charles! This is a huge help. I've been getting exited about slowly updating some of the OLED screen behavior. I think that the interface does need to shift more towards an "opt-in" to notifications for better usability. It's tricky to try to implement a good usable UI on a tiny screen with a single user button.

@crossan007
Copy link
Contributor

In that meshtastic-device branch, I also made some changes to the underlying OLED driver, which I just now realized were actually merged into master 😬 I think the changes were probably "ready", but they're not yet being used by Meshtastic.

meshtastic/esp8266-oled-ssd1306@a589780

@mc-hamster
Copy link
Member

Thanks!

@mc-hamster mc-hamster merged commit 0118f39 into meshtastic:master Nov 29, 2021
@geeksville
Copy link
Member

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/meshtastic-device-1-2-48-alpha/4359/1

@geeksville
Copy link
Member

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/meshtastic-device-1-2-49-5354c49-alpha/4502/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants