fix create_node and start_stop_node #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- logdir -> incidents_dir - storedir -> storage_dir - removed unnecessary os.path.join - removed default "" argument to config.get (there is a None there anyway)
turns out it was actually necessary if you want to run things
allow create-introducer et al to set web.port, incidents_dir and tempdir
instead of relative to the basedir
this was actually returning None anyway, because these options are actually present in the dictionary with values of None when they are not specified on the commandline.
No web ui for introducers has been the default behavior for a long time, so lets leave it that way now even though create-introducer can configure a web.port now. This also makes the one test that was failing pass.
|
They look good to me. |
meskio
added a commit
that referenced
this pull request
Feb 1, 2014
fix create_node and start_stop_node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes create_node and start_stop_node able to work again. (I've merged this into my truckee branch and tested it successfully with my quickgrid.sh script there.)
See further comments at https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2045#comment:36