systemd build broken by #5065 #5113

jon-turney · 2019-03-18T21:32:12Z

See https://travis-ci.org/jon-turney/meson-corpus-test/jobs/508033325#L1596

Bisecting meson lands on commit 07818da

I think this may be related somehow to -lrt being de-duplicated in a linking command line?

The text was updated successfully, but these errors were encountered:

jon-turney · 2019-03-18T21:47:47Z

jon@bionic:~/src$ git clone https://github.com/jon-turney/meson-corpus-test-update
[...]
jon@bionic:~/src$ cd meson-corpus-test-update/
jon@bionic:~/src/meson-corpus-test-update$ ./run systemd
[...]
[584/1778] Linking target libnss_myhostname.so.2.
FAILED: libnss_myhostname.so.2 
cc  -o libnss_myhostname.so.2 'nss_myhostname@sha/src_nss-myhostname_nss-myhostname.c.o' 'nss_myhostname@sha/src_libsystemd_disable-mempool.c.o' -Wl,--no-undefined -Wl,--as-needed -shared -fPIC -Wl,--start-group -Wl,-soname,libnss_myhostname.so.2 -Wl,-z,relro -Wl,-z,now src/libsystemd/libsystemd_static.a src/basic/libbasic.a -Wl,-z,nodelete -shared -Wl,--version-script=/systemd/src/nss-myhostname/nss-myhostname.sym -Wl,--undefined -lrt /usr/lib/i386-linux-gnu/libcap.so /usr/lib/i386-linux-gnu/libselinux.so -lm -Wl,--end-group -pthread '-Wl,-rpath,$ORIGIN/src/libsystemd:$ORIGIN/src/basic' -Wl,-rpath-link,/systemd/_build/src/libsystemd:/systemd/_build/src/basic 
src/libsystemd/libsystemd_static.a(sd-daemon_sd-daemon.c.o): In function `sd_is_mq':
/systemd/_build/../src/libsystemd/sd-daemon/sd-daemon.c:411: undefined reference to `mq_getattr'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
jon@bionic:~/src/meson-corpus-test-update$ ./run systemd --commit 5f00c302
[...]
[1777/1778] Installing files.
[...]

jon-turney · 2019-03-18T21:48:12Z

This should probably be tagged for 0.50.1, as #5065 was.

jpakkane · 2019-04-06T19:22:05Z

It may be that this is not a bug in Meson after all. Systemd has this in its build definition files:

                        link_args : ['-Wl,-z,nodelete',
                                     '-shared',
                                     '-Wl,--version-script=' + version_script_arg,
                                     '-Wl,--undefined'],

The last one of these is wrong from what I can tell. Ld's man page says the following:

       -u symbol
       --undefined=symbol
           Force symbol to be entered in the output file as an undefined symbol.  Doing this may, for example, trigger linking of additional modules from standard libraries.  -u may
           be repeated with different option arguments to enter additional undefined symbols.  This option is equivalent to the "EXTERN" linker script command.

           If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option
           --require-defined should be used instead.

This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break.

This patch to systemd makes it compile:

diff --git a/meson.build b/meson.build
index 287125f010..79195c9748 100644
--- a/meson.build
+++ b/meson.build
@@ -1606,8 +1606,7 @@ foreach tuple : [['myhostname', 'ENABLE_NSS_MYHOSTNAME'],
                         # Note that we link NSS modules with '-z nodelete' so that mempools never get orphaned
                         link_args : ['-Wl,-z,nodelete',
                                      '-shared',
-                                     '-Wl,--version-script=' + version_script_arg,
-                                     '-Wl,--undefined'],
+                                     '-Wl,--version-script=' + version_script_arg],
                         link_with : [libsystemd_static,
                                      libbasic],
                         dependencies : [threads,

Ping @keszybz

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113

keszybz · 2019-04-06T20:04:52Z

systemd/systemd#12232

jpakkane · 2019-04-07T00:03:33Z

Thanks. Closing this.

jon-turney · 2019-04-07T14:12:04Z

Thanks

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113 (cherry picked from commit 700805f)

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113 (cherry picked from commit 700805f6c546f2adb79059614f3747f7b5474325)

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128daba7236a6080383b2a5649033cfef85c. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113 (cherry picked from commit 700805f6c546f2adb79059614f3747f7b5474325)

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113 (cherry picked from commit 700805f)

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128daba7236a6080383b2a5649033cfef85c. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128daba7236a6080383b2a5649033cfef85c. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113 (cherry picked from commit 700805f6c546f2adb79059614f3747f7b5474325)

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113 (cherry picked from commit 700805f) Related: CVE-2020-1712

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113 (cherry picked from commit 700805f) (cherry picked from commit 0ed1150)

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113 (cherry picked from commit 700805f) Related: CVE-2020-1712

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113 (cherry picked from commit 700805f) [fbui: adjust context]

Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128daba7236a6080383b2a5649033cfef85c. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] mesonbuild/meson#5113 (cherry picked from commit 700805f6c546f2adb79059614f3747f7b5474325)

jon-turney mentioned this issue Mar 18, 2019

compilers: Try harder to dedup builtin libs #5065

Merged

nirbheek added this to the 0.50.1 milestone Mar 27, 2019

keszybz mentioned this issue Apr 6, 2019

meson: drop misplaced -Wl,--undefined argument systemd/systemd#12232

Merged

jpakkane closed this as completed Apr 7, 2019

mrc0mmand mentioned this issue Apr 18, 2019

(#1701217) meson: drop misplaced -Wl,--undefined argument lnykryn/systemd-rhel#328

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

systemd build broken by #5065 #5113

systemd build broken by #5065 #5113

jon-turney commented Mar 18, 2019 •

edited

Loading

jon-turney commented Mar 18, 2019

jon-turney commented Mar 18, 2019

jpakkane commented Apr 6, 2019

keszybz commented Apr 6, 2019

jpakkane commented Apr 7, 2019

jon-turney commented Apr 7, 2019

systemd build broken by #5065 #5113

systemd build broken by #5065 #5113

Comments

jon-turney commented Mar 18, 2019 • edited Loading

jon-turney commented Mar 18, 2019

jon-turney commented Mar 18, 2019

jpakkane commented Apr 6, 2019

keszybz commented Apr 6, 2019

jpakkane commented Apr 7, 2019

jon-turney commented Apr 7, 2019

jon-turney commented Mar 18, 2019 •

edited

Loading