Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vs_module_defs should except empty list orempty string #5462

Open
dcbaker opened this issue Jun 7, 2019 · 0 comments
Open

vs_module_defs should except empty list orempty string #5462

dcbaker opened this issue Jun 7, 2019 · 0 comments
Labels
bug OS:windows Winodows OS specific issues

Comments

@dcbaker
Copy link
Member

dcbaker commented Jun 7, 2019

If you need one for when building with msvc but not with mingw it means duplicating the entire library call
@dcbaker dcbaker added bug OS:windows Winodows OS specific issues labels Jun 7, 2019
mmatuska pushed a commit to libarchive/bzip2 that referenced this issue Feb 9, 2020
@dcbaker
meson: Support dlls with msvc
6b3d675 
I've filed mesonbuild/meson#5462 about the
fact that vs_module_defs cannot accept an empty list (the usual way in
meson to say "nothing" (like NULL, None, etc).

This allows msvc to compile a bz2-1.dll that at least passes the tests
provided.

The .def file doesn't work for mingw due to (I think) differences in the
way msvc and mingw define .def files. I *think*, but I'm not positive,
it has to do with stdcall vs cdecl, but I'm just throwing stuff at the
wall till it sticks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug OS:windows Winodows OS specific issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcbaker