Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override_options: ['buildtype=release'] not working, possible regression. #5920

Open
mkrogius opened this issue Sep 12, 2019 · 3 comments
Open

Comments

@mkrogius
Copy link

I have specified override_options: ['buildtype=release'] in one of my executable targets.

On meson 0.46.1 this correctly adds -O3. On meson versions 0.49.2 and 0.51.2 it does not.

@byron-hawkins
Copy link

Same problem on Meson 0.55.3, more than a year later. Is there a reason this does not add the -O3 flag as the documentation implies it should?

@sofar
Copy link

sofar commented Apr 26, 2021

Similarly, optimization=3 is broken as well - override_options does not undo a project wide setting.

@eli-schwartz
Copy link
Member

https://mesonbuild.com/Release-notes-for-0-48-0.html#toggles-for-build-type-optimization-and-vcrt-type

In 0.48 (between the two versions originally reported) we added a finer-grained way to set these options. The buildtype is synced at setup time with those values, and ultimately what is used is optimization/debug, not buildtype.

Maybe we should be checking this again during override_options processing. That being said, override_options: ['optimization=3'] is NOT broken in my testing.

bruchar1 added a commit to bruchar1/meson that referenced this issue Dec 1, 2023
bruchar1 added a commit to bruchar1/meson that referenced this issue Dec 2, 2023
bruchar1 added a commit to bruchar1/meson that referenced this issue Dec 5, 2023
jpakkane pushed a commit that referenced this issue Dec 23, 2023
This is a first step to make `buildtype` a true alias of `debug` and
`optimization` options.

See #10808.

Relates to:
- #11645
- #12096
- #5920
- #5814
- #8220
- #8493
- #9540
- #10487
- #12265
- #8308
- #8214
- #7194
- #11732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants