Fix regression in test definitions #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignatenkobrain
approved these changes
Sep 7, 2017
|
Appveyor test failure seems relevant. |
Caused by #2236. Also add a test for this.
|
⚔️ conflicts. |
To avoid platform-specific differences in git settings.
|
Looks like tests all pass now. |
|
It's not green yet. 😄 |
|
That last one is gonna take 5-10 more minutes, so to speed things up I'm going to push the patch to the 0.42 branch in advance :p Do you want it as two commits or one commit squashed? |
|
Merged. Feel free to add it to your branch how ever you see fit. |
|
The 0.42 branch is all pushed. I'll just test it against my list of repos locally and we can call it a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by #2236. Also add a test for this.