backends: Add custom target inc dirs before target inc dirs #2291
Conversation
|
This needs a test. |
|
Added. |
Codecov Report
@@ Coverage Diff @@
## master #2291 +/- ##
=========================================
Coverage ? 52.71%
=========================================
Files ? 74
Lines ? 18449
Branches ? 3855
=========================================
Hits ? 9725
Misses ? 7690
Partials ? 1034
Continue to review full report at Codecov.
|
|
Linux builds are failing because |
|
Linux and macOS were passing a little while ago, so the relevant change is that appveyor MSVC passes again. I think this can be merged. |
|
Oh, nvm, that was when there was no test and I was thinking about #2288 for appveyor failures. |
Custom target include dirs must be overridable by target-specific include dirs otherwise in case of header name collisions, the user has no way to override this behaviour.
|
I'm surprised that custom target dirs are added automatically in the search path. Git blame says that the original commit message does not state this change in behaviour, only that the order changes. Still, since we have this, it really should work properly. |
|
git blame can be a bit wonky at times. I manually searched for the commit that added it, and it seems it was f9060a7#diff-2f566b4da6de635b323a7c47114652d8R1200 in 2015. There's still no reason as to why it was added, but we should indeed keep it around. |
With these changes gtk+ builds for me using fallbacks for all libraries with fallbacks available. Needs the following changes: ebassi/graphene#109 (graphene) https://bugzilla.gnome.org/show_bug.cgi?id=787414 (pango) mesonbuild/meson#2291 (will be in meson 0.42.1) https://bugzilla.gnome.org/show_bug.cgi?id=787416
Custom target include dirs must be overridable by target-specific include dirs otherwise in case of header name collisions, the user has no way to override this behaviour. This is happening right now for gtk+ and graphene when graphene is used via a subproject.