Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple inputs to configure_file() #5701

Closed
wants to merge 1 commit into from

Conversation

elmarco
Copy link
Contributor

@elmarco elmarco commented Jul 24, 2019

For command, it is useful to be able to express multiple input files,
just like custom_target().

WIP until tests are added, and probably some FeatureNew checks etc.

@xclaesse
Copy link
Member

I think command can be an array with files in the command arguments. That doesn't work?

@nirbheek
Copy link
Member

input: is useful when you want to tell meson to reconfigure if that file changes, so this sounds useful in case you're generating something using multiple input files.

@xclaesse
Copy link
Member

I meant that if you have files in the command: [] kwarg, it will also add them into deps. But I guess there could be cases where you want to add deps that are not explicitly passed to the command line.

For command, it is useful to be able to express multiple input files,
just like custom_target().
@elmarco elmarco marked this pull request as ready for review July 26, 2019 14:48
@elmarco elmarco changed the title WIP: Add multiple inputs to configure_file() Add multiple inputs to configure_file() Jul 26, 2019
@elmarco
Copy link
Contributor Author

elmarco commented Aug 29, 2019

ping (required by qemu port)

thanks

@xclaesse
Copy link
Member

I totally forgot about this MR, and I ran into the same problem, so I re-made pretty much the same patch: #5895.

@elmarco I think my patch there is slightly better because it covers 2 related issues. I shamelessly copied your release snippet :)

@elmarco
Copy link
Contributor Author

elmarco commented Sep 10, 2019

@xclaesse nm, that happens to me as well. Let's close and take your version if it's better.

@xclaesse
Copy link
Member

Ok, thanks. Closing this now.

@xclaesse xclaesse closed this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants