Allow add_dist_script() in subprojects #8444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't look over the implementation too closely, but I'm fine with idea. Consider this an acked-by |
|
The thing that concerns me is that this may cause problems when people start disting subprojects that have not been updated to work with this. Dunno if we can do anything about it, though... |
|
They certainly won't work out of the box, they have to be ported to use MESON_PROJECT_ variables otherwise all paths are going to be wrong. But since it's currently not allowed to call add_dist_script from a subproject, it can't create regressions. |
jpakkane
reviewed
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8440.