fix regression that broke string.format with list objects #9532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String formatting should validly assume that printing a list means printing the list itself. Instead, something like this broke: 'one is: @0@ and two is: @1@'.format(['foo', 'bar'], ['baz']) which would evaluate as: 'one is: foo and two is: bar' or: 'the value of array option foobar is: @0@'.format(get_option('foobar')) which should evaluate with '-Dfoobar=[]' as 'the value of array option foobar is: []' But instead produced: meson.build:7:0: ERROR: Format placeholder @0@ out of range. Fixes mesonbuild#9530
dcbaker
approved these changes
Nov 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #9532 +/- ##
==========================================
- Coverage 67.41% 67.39% -0.03%
==========================================
Files 396 396
Lines 85562 85564 +2
Branches 17665 17665
==========================================
- Hits 57684 57665 -19
- Misses 23214 23243 +29
+ Partials 4664 4656 -8
Continue to review full report at Codecov.
|
This is configured as: but apparently it now works? Do you know why, or if it is expected to stay that way? (I genuinely have no idea when tests are/were expected to be skipped, or why, to begin with.) |
|
I guess you mean Why was it skipped in the first place? |
|
ah, I'd guess this is msys2/MINGW-packages@345fe43 which got uploaded 4 days ago, so likely fixed and can be unskipped. |
lazka
added a commit
to lazka/meson
that referenced
this pull request
Nov 5, 2021
See mesonbuild#9532 (comment) for context. It's unclear why this was skipped exactly in the first place, but it started to pass recently and MSYS2 fixed some cmake+llvm related things in msys2/MINGW-packages@345fe43 at the same time, so this is likely the reason.
|
I've created #9534 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String formatting should validly assume that printing a list means printing the list itself. Instead, something like this broke:
which would evaluate as:
or:
which should evaluate with '-Dfoobar=[]' as
But instead produced:
Fixes #9530