tests: unskip a test on msys2 that now works #9534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See mesonbuild#9532 (comment) for context. It's unclear why this was skipped exactly in the first place, but it started to pass recently and MSYS2 fixed some cmake+llvm related things in msys2/MINGW-packages@345fe43 at the same time, so this is likely the reason.
Codecov Report
@@ Coverage Diff @@
## master #9534 +/- ##
==========================================
- Coverage 67.39% 64.30% -3.10%
==========================================
Files 396 198 -198
Lines 85564 42739 -42825
Branches 17665 8737 -8928
==========================================
- Hits 57667 27482 -30185
+ Misses 23241 12974 -10267
+ Partials 4656 2283 -2373 Continue to review full report at Codecov.
|
|
Test failure is relevant: So it is still unexpectedly skipped when link_static == True? |
|
hm, but why? I might be missing something re how this works then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9532 (comment)
for context.
It's unclear why this was skipped exactly in the first place, but it started to
pass recently and MSYS2 fixed some cmake+llvm related things in
msys2/MINGW-packages@345fe43
at the same time, so this is likely the reason.