-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zpp_bits: Add new wrap 4.4.22 #1574
base: master
Are you sure you want to change the base?
Conversation
of course sanity checks pass on local machine... |
You forgot to update As for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file must be removed.
wait, i include whole directory and not just .h file |
Why? |
because it was including junk like readme.md and I could't find another way to move this header file or force including just header file |
If by included, you mean add the directory to the include flags, yes… So? You're afraid someone is going to use And you could have just used |
i tried and it didn't see the include directory |
Please post the code you used. |
|
That's not how
Try something like this:
project(
'zpp_bits',
'cpp',
version: '4.4.22',
license: 'MIT',
meson_version: '>=0.64.0',
)
subdir('include')
zpp_bits_dep = declare_dependency(include_directories: incdir)
copy = import('fs').copyfile('../zpp_bits.h')
incdir = include_directories('.') |
(And go back to the original upstream source distribution). |
i think meson.build will still be included this way |
What do you mean included? |
i mean it's in the same directory as header |
IHMO, you could have kept the original code. The real use case for
So? You'll have multiple instances of that in the wraps provided (with makefiles, source files…). Unless someone is foolish enough to try to |
maybe i'm perfectionist but i don't like that my tools reports that meson.build is one of the headers ready to be included |
but as you mentioned, other wraps do that so now i don't care |
of course i'm stupid - i forget to set c++ at least to c++20 |
@@ -3686,4 +3694,4 @@ | |||
"1.3.3-1" | |||
] | |||
} | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhhh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why it did that, maybe because it's second to last so maybe it's some problem with trailing comma that makes diff freak out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you removed the terminating newline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was that bad?
I'm not sure if meson_version: '>=1.0.1' should be so high but this is the one i'm using right now