-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expat: Add XML_STATIC to dependency #237
Conversation
(If/when this is merged, it'd be lovely if this could be released as |
You add a new revision to releases.json with your MR, then a new version will be created on merge. See https://github.com/mesonbuild/wrapdb/blob/master/README.md |
Woops, apologies for missing what is very clearly stated in the README. I updated |
Please squash both commits into one.
|
be0c636
to
bc5c6e9
Compare
Done! |
The CI is now complaining that this would be a good time to finally make the expat wrap obey standards by including a |
bc5c6e9
to
f0ede7e
Compare
|
Not that it changed -- that the .wrap file and the releases.json disagree about what is there. You need to add it to both. |
f0ede7e
to
f32ac87
Compare
The current use of `add_project_arguments` works when compiling expat itself, but it doesn't work when expat is a meson subproject of another meson project. Adding it as a `compile_args` of `declare_dependency` makes that usecase work. Also, release expat 2.2.9-4 Also, add [provide] section to `expat.wrap`
f32ac87
to
41196db
Compare
Got it - fixed that, and rebase on main, It fails on Windows/MSVC for me:
..but manually running Here's what my manual dynamic build does:
(Which seems correct, using And here's what my manual static build does:
(Which seems correct too, not pulling in the |
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA |
Ok, retriggering it worked. |
Thanks! |
Thanks for helping drive this to the finish line! Really appreciate it 💖 |
The intermittent error happens because GitHub releases artifacts uses Azure instead of AWS to combat the AWS outage, but seemingly GitHub's service account is not in good standing with their own parent company. |
This provides the XML_STATIC definition when cairo is built as a static library on Windows, see mesonbuild/wrapdb#237
The current use of
add_project_arguments
works when compiling expatitself, but it doesn't work when expat is a meson subproject of another
meson project.
Adding it as a
compile_args
ofdeclare_dependency
makes that usecasework.
See also: