Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: document or improve handling of master disconnections #277

Closed
ajwerner opened this issue Feb 6, 2017 · 2 comments
Closed

next: document or improve handling of master disconnections #277

ajwerner opened this issue Feb 6, 2017 · 2 comments

Comments

@ajwerner
Copy link
Contributor

ajwerner commented Feb 6, 2017

Right now the httpsched doesn't deal with disconnections from the master particularly well. Future attempts to re-subscribe on the same httpsched return errAlreadySubscribed. Currently my answer is to detect the error then mark the Context as Done and create a new httpsched. Is this the right approach?

https://github.com/mesos/mesos-go/blob/next/httpcli/httpsched/state.go#L123

@jdef jdef added the class/bug label Feb 12, 2017
@jdef
Copy link
Contributor

jdef commented Feb 25, 2017

That's probably the best way to handle it for now. Need to carefully consider how much additional intelligence should be built into the httpsched client vs. delegating to frameworks.

@jdef
Copy link
Contributor

jdef commented Apr 24, 2017

fixed by #286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants