feature flag opt-in for re-subscribe #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! The scheduler not receiving heartbeat signals from the master is a good example of a condition not picked up by the default error detection in the httpsched impl. |
jdef
requested changes
Nov 20, 2017
| @@ -96,6 +97,14 @@ func MaxRedirects(mr int) Option { | |||
| } | |||
| } | |||
|
|
|||
| func AllowReconnection(v bool) Option { | |||
There was a problem hiding this comment.
mind writing a minimal comment for this func that explains how it effectively alters the behavior of the client?
There was a problem hiding this comment.
i'm going to add comments in a subsequent PR
jdef
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the v1 scheduler workflow isn't re-subscribe friendly, which makes implementing proper heartbeat handling in a framework tricky.
This PR adds the bare minimum hooks necessary to test out re-SUBSCRIBE on an opt-in basis. It "should" be safe to do without the feature-flag, but the comments by jdef in the source imply otherwise.
Doing this without the opt-in does have repercussions on anyone who is currently invoking a SUBSCRIBE call. To avoid issues with receiving one last
scheduler.Event_ERRORmessage on the old subscription socket, you have to do some additional state tracking in framework code to correctly handle it. As I'm not using the helpers in theextrasdirectory, I'm not sure the right way to handle the workflow there so I didn't make any changes to try and use the re-subscribe changes there.