Add support for multiple disks resources #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Would you mind fleshing out |
everpcpc
changed the title
|
Hi, I've put the tests in |
jdef
reviewed
Sep 8, 2017
api/v1/lib/resources.go
Outdated
| buf.WriteString(m.GetRoot()) | ||
| } | ||
| default: | ||
| buf.WriteString("(ROOT:") |
There was a problem hiding this comment.
can we get rid of ROOT: output here? I'd like for the output to be mostly consistent with https://github.com/apache/mesos/blob/1.2.x/src/common/resources.cpp#L1922
| @@ -72,7 +72,7 @@ func Reservation(ri *mesos.Resource_ReservationInfo) Opt { | |||
| } | |||
| } | |||
|
|
|||
| func Disk(persistenceID, containerPath string) Opt { | |||
| func Disk(persistenceID, containerPath, source string, sourceType mesos.Resource_DiskInfo_Source_Type) Opt { | |||
There was a problem hiding this comment.
nit: would rather have left the params for Disk alone and created a new DiskWithSource func w/ the extended params. Callers of Disk(x, y, "", 0) shouldn't actually need to bother with the additional params.
|
thanks, lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disk source should also be checked. Otherwise it will cause a mistaken resource comparison when using multiple disks.