Implement backup/restore to Azure blob storage #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbrowning
force-pushed
the
mrb/azure-backups
branch
from
08fb01c
to
07aaa11
Compare
mohitsoni
reviewed
May 4, 2017
| upload-azure: | ||
| goal: FINISHED | ||
| cmd: > | ||
| az login -u $CLIENT_ID --service-principal --tenant $TENANT_ID -p $CLIENT_SECRET |
There was a problem hiding this comment.
I'm sure this is correct, but I'll still ask. Does --service-principal takes an argument like other flags in this command ?
There was a problem hiding this comment.
No, it's just a boolean flag that tells the Azure CLI client what type of principal the argument to -u is. Seems to work as exercised by the integration test :)
mrbrowning
force-pushed
the
mrb/azure-backups
branch
from
ded1978
to
1eec204
Compare
|
@mesosphere-ci retest this please |
|
Cluster launch is failing. |
mrbrowning
force-pushed
the
mrb/azure-backups
branch
from
1eec204
to
60fb3f4
Compare
added 7 commits
May 5, 2017 14:33
…ing the run ID change
mrbrowning
force-pushed
the
mrb/azure-backups
branch
from
60fb3f4
to
23d46dd
Compare
|
Failed in nightly, please take a look. |
|
Looks like I failed to add the relevant secrets for Azure access, fixed and rerunning now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.