add support for framework v1.1.1-1.10.4 #90
Conversation
There was a problem hiding this comment.
@rimusz thank you very much for working on this! I have some remarks/questions but this is looking great!
README.md
Outdated
| @@ -85,6 +106,8 @@ To deploy a **highly-available** cluster with three (3) private and one (1) publ | |||
| } | |||
| ``` | |||
|
|
|||
| **NOTE:** The **highly-available** mode for a cluster must be chosen when installing the package. Changing the highly-available mode after installing the package is not supported. | |||
There was a problem hiding this comment.
@rimusz one can change kubernetes.high_availability from false to true (but not the other way around) after installing the package.
|
|
||
| ## Pre-Requisites | ||
|
|
||
| First, make sure your cluster fulfils the [Kubernetes package default requirements](https://docs.mesosphere.com/service-docs/kubernetes/1.0.3-1.9.7/install/#prerequisites/). | ||
| First, make sure your cluster fulfils the [Kubernetes package default requirements](https://docs.mesosphere.com/service-docs/kubernetes/1.1.1-1.10.4/install/#prerequisites/). |
There was a problem hiding this comment.
@rimusz make deploy (that we run later) will provision a cluster according to the prerequisites, so what exactly does one need to make sure here?
There was a problem hiding this comment.
one has enough cloud resources
Makefile
Outdated
| .PHONY: setup-cli | ||
| setup-cli: check-dcos | ||
| @echo "Sleep for 15 seconds ..." | ||
| @sleep 15 |
There was a problem hiding this comment.
@rimusz why do we need to sleep?
There was a problem hiding this comment.
to wait for master be ready, specially it happens on AWS
There was a problem hiding this comment.
Can we poll until the DC/OS master is up instead?
Makefile
Outdated
| $(call get_public_agent_ip) | ||
| $(DCOS_CMD) kubernetes kubeconfig --apiserver-url https://$(PUBLIC_AGENT_IP):6443 --insecure-skip-tls-verify | ||
| @echo "Sleep for 25 seconds ..." | ||
| @sleep 25 |
There was a problem hiding this comment.
@rimusz why do we need to sleep?
There was a problem hiding this comment.
same here, better put some delay, as otherwise kubeapi is not available right after the above command
There was a problem hiding this comment.
Can we poll until the Kubernetes API is up instead?
docs/aws.md
Outdated
| @@ -73,6 +73,28 @@ For more advanced scenarios, please check the [terraform-dcos documentation for | |||
|
|
|||
| ### Kubernetes configuration | |||
|
|
|||
| #### RBAC | |||
|
|
|||
| **NOTE:** By default, it will provision a Kubernetes cluster without [RBAC](https://docs.mesosphere.com/services/kubernetes/1.1.1-1.10.4/authn-and-authz/#rbac) support. | |||
There was a problem hiding this comment.
@rimusz perhaps s/it/dcos-kubernetes-quickstart.
There was a problem hiding this comment.
I suggest replacing it will provision with this quickstart provisions.
docs/aws.md
Outdated
| @@ -89,6 +111,8 @@ To deploy a **highly-available** cluster with three (3) private and one (1) publ | |||
| } | |||
| ``` | |||
|
|
|||
| **NOTE:** The **highly-available** mode for a cluster must be chosen when installing the package. Changing the highly-available mode after installing the package is not supported. | |||
There was a problem hiding this comment.
@rimusz please see the comment above about kubernetes.high_availability.
docs/azure.md
Outdated
| @@ -68,6 +68,27 @@ For more advanced scenarios, please check the [terraform-dcos documentation for | |||
|
|
|||
| ### Kubernetes configuration | |||
|
|
|||
| #### RBAC | |||
|
|
|||
| **NOTE:** By default, it will provision a Kubernetes cluster without [RBAC](https://docs.mesosphere.com/services/kubernetes/1.1.1-1.10.4/authn-and-authz/#rbac) support. | |||
There was a problem hiding this comment.
@rimusz perhaps s/it/dcos-kubernetes-quickstart/.
There was a problem hiding this comment.
Why are we repeating text in all docs?
docs/azure.md
Outdated
| @@ -83,6 +104,8 @@ To deploy a **highly-available** cluster with three (3) private and one (1) publ | |||
| } | |||
| ``` | |||
|
|
|||
| **NOTE:** The **highly-available** mode for a cluster must be chosen when installing the package. Changing the highly-available mode after installing the package is not supported. | |||
There was a problem hiding this comment.
@rimusz please see the comment above about kubernetes.high_availability.
| @@ -0,0 +1,23 @@ | |||
| { | |||
| "id": "/kubeapi-proxy", | |||
There was a problem hiding this comment.
@rimusz I got kubeapi-proxy as well as marathon-lb. Could we stick to a single one or have that as as an option of the Makefile target?
There was a problem hiding this comment.
we need both, as kube-proxy is just a dummy marathon app with traffic forward to k8s API and marathon-lb which exposes it to internet
…olling for dc/s master and kubernetes api
includes kubernetes API access via marathon-lb
Fixes #88