Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean yum cache after adding repos #1081

Merged
merged 2 commits into from
May 20, 2024
Merged

fix: clean yum cache after adding repos #1081

merged 2 commits into from
May 20, 2024

Conversation

supershal
Copy link
Collaborator

@supershal supershal commented May 17, 2024

What problem does this PR solve?:

  • Always clean yum cache after adding kubernetes repositories

Once we add a repo to the yum cache, we need to update the yum caches so that the packages from the repo can be downloaded.
when we install ansible packages we do use update_cache: yes option. https://docs.ansible.com/ansible/latest/collections/ansible/builtin/yum_module.html#parameter-update_cache
however it will clean the cache only if it is expired. So the new packages are not getting downloaded automatically even after ansible invokes update cache.
This PR forces yum to clean all yum caches including repo mirror list so that package list can be refreshed automatically.

Which issue(s) does this PR fix?:

@supershal supershal self-assigned this May 17, 2024
@github-actions github-actions bot added the fix label May 17, 2024
@supershal supershal requested review from dkoshkin and faiq May 17, 2024 23:22
Copy link
Contributor

@dkoshkin dkoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a description in the PR why this is needed.

@github-actions github-actions bot added fix and removed fix labels May 20, 2024
@supershal supershal changed the title fix: clean yum cache after adding repos fix: clean yum cache after adding repos May 20, 2024
@github-actions github-actions bot added fix and removed fix labels May 20, 2024
@supershal supershal merged commit ce71dd6 into main May 20, 2024
37 of 53 checks passed
@supershal supershal deleted the shalin/clean-cache branch May 20, 2024 21:37
supershal added a commit that referenced this pull request May 20, 2024
* fix: clean yum cache after adding repos

* fix: clean cache for rhel/centos 7 only
supershal added a commit that referenced this pull request May 20, 2024
* fix: clean yum cache after adding repos

* fix: clean cache for rhel/centos 7 only
supershal added a commit that referenced this pull request May 20, 2024
* fix: clean yum cache after adding repos

* fix: clean cache for rhel/centos 7 only
supershal added a commit that referenced this pull request May 20, 2024
* fix: clean yum cache after adding repos

* fix: clean cache for rhel/centos 7 only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants