-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace broken centos 8 appstream repo with alma linux repos #227
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7a447f5 |
0870ae3
to
66eef33
Compare
It does:
|
Wherever we use Centos 8 docker image or AMI, the "appstream" and "baseos" mirror list are broken. We have to either replace with some other repo or use fixed working "base_url" instead of mirror list. |
# The correct epel-release rpms will be downloaded for Centos, RHEL and oracle 7 repos from in-built extra repos | ||
# epel-release for Centos/RHEL/Oracle 8 will be installed using Alma linux "extra" repository | ||
- name: install epel-release | ||
yum: | ||
name: epel-release | ||
state: present |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the in-built extra repos coming from? Just a little confused Oracle7 seems to be failing on this for some reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in-built extra repos are installed with the OS in /etc/yum.repos.d/
. each distribution has its own base
, extra
and appstream
repos. Those are not always in sync 100% with their upstream
counter part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added back centos 7 repositories. The changes in this PR only affects centos 8 based repos.
sed 's/$/{{ '_' + kubernetes_build_tag if kubernetes_build_tag }}/' | | ||
sed 's/^\(.\+pause:.\+\)_{{ kubernetes_build_tag }}$/\1/' | ||
sed 's/^\(.\+pause:.\+\)_{{ kubernetes_build_tag }}$/\1/' | | ||
sed 's#^\(.\+coredns:\)\(.\+\)_{{ kubernetes_build_tag }}#{{ coredns_image_registry_repository }}:\2#' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit ugly fix to make etcd
and coredns
images work for both FIPS and non-FIPS versions.
I intend to rewrite it in future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non FIPS images:
(item=k8s.gcr.io/kube-apiserver:v1.21.6)
(item=k8s.gcr.io/kube-controller-manager:v1.21.6)
(item=k8s.gcr.io/kube-scheduler:v1.21.6)
(item=k8s.gcr.io/kube-proxy:v1.21.6)
(item=k8s.gcr.io/pause:3.4.1)
(item=k8s.gcr.io/etcd:3.4.13-0)
(item=k8s.gcr.io/coredns/coredns:v1.8.0)
(item=k8s.gcr.io/pause:3.2)
(item=docker.io/mesosphere/kfips:v0.1.0)
FIPS changes:
(item=docker.io/mesosphere/kube-apiserver:v1.21.6_fips.0)
(item=docker.io/mesosphere/kube-controller-manager:v1.21.6_fips.0)
(item=docker.io/mesosphere/kube-scheduler:v1.21.6_fips.0)
(item=docker.io/mesosphere/kube-proxy:v1.21.6_fips.0)
(item=docker.io/mesosphere/pause:3.4.1)
(item=docker.io/mesosphere/etcd:v3.4.13_fips.0)
(item=k8s.gcr.io/coredns/coredns:v1.8.0)
(item=k8s.gcr.io/pause:3.2)
(item=docker.io/mesosphere/kfips:v0.1.0)
@faiq @dkoshkin The builds were breaking at multiple points because of two issues: Centos 8 deprecation and bug in pulling fips images.
|
Should we move "E2E CentOS 7 NVIDIA (Konvoy Image Builder" builds on Main branch only or nightly build? Or we can try to build images in different AWS region so that PRs not blocked by the lack of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What problem does this PR solve?:
The centos 8 appstream repo is deprecated and not available anymore. this breaks builds at multiple points.
Deprecation reference links:
https://centos.org/cl-vs-cs/
https://forums.centos.org/viewtopic.php?f=54&t=78026
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: