Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove k8s version override from ui #64

Merged
merged 2 commits into from
May 5, 2020
Merged

remove k8s version override from ui #64

merged 2 commits into from
May 5, 2020

Conversation

juliangieseke
Copy link
Contributor

No description provided.

@juliangieseke juliangieseke requested review from a team as code owners April 28, 2020 16:08
@juliangieseke juliangieseke self-assigned this Apr 28, 2020
@juliangieseke juliangieseke changed the title [master] D2IQ-67811: add 1.16.8 k8s version [master] D2IQ-67811: remove k8s version override from ui Apr 28, 2020
@juliangieseke juliangieseke changed the title [master] D2IQ-67811: remove k8s version override from ui remove k8s version override from ui Apr 28, 2020
shaneutt
shaneutt reviewed Apr 28, 2020
View reviewed changes
Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up, Kudo (which is required for several of the catalog addons) does not support old versions of Kubernetes. As such you may want to consider having a supported minimum version declared.

@juliangieseke
Copy link
Contributor Author

@shaneutt UI doesnt consume that var anymore, it was removed a while back. your point is valid, but should be solved in KCL utility server. I'll figure out what the status is 👍

@shaneutt
Copy link
Contributor

@shaneutt UI doesnt consume that var anymore, it was removed a while back. your point is valid, but should be solved in KCL utility server. I'll figure out what the status is +1

Ok, sounds good 👍

@shaneutt shaneutt merged commit dcbb214 into master May 5, 2020
@shaneutt shaneutt deleted the jg/k8s-versions branch May 5, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makkes makkes makkes approved these changes

@shaneutt shaneutt shaneutt approved these changes

@GeorgiSTodorov GeorgiSTodorov GeorgiSTodorov approved these changes

Assignees

@juliangieseke juliangieseke

Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juliangieseke @shaneutt @makkes @GeorgiSTodorov