Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump awsebscsiprovisioner to chart 0.3.8 (#273) #275

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

joejulian
Copy link
Contributor

@joejulian joejulian commented Jun 2, 2020

What type of PR is this?

Bug

What this PR does/ why we need it:

Enables cleanupVolumeSnapshotCRDV1alpha1 by default.

This makes upgrade automatic without manual steps listed in #244 .

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[awsebscsiprovisioner] The manual steps to upgrade the snapshot APIs from v1alpha1 to v1beta1 is no longer required. It has been automated in the chart CRD install hook by default. If you do not want that default behavior of cleaning up v1alpha1 snapshot CRDs, you can set `cleanupVolumeSnapshotCRDV1alpha1` to `false` and follow the instructions for upgrading to Kubernetes `1.17`.

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

* chore: prepare awsebscsiprovisioner bump

* chore: awsebscsiprovisioner bump

[D2IQ-68987]

[D2IQ-68987]: https://jira.d2iq.com/browse/D2IQ-68987
@joejulian joejulian requested a review from a team as a code owner June 2, 2020 21:55
@joejulian joejulian self-assigned this Jun 2, 2020
@joejulian
Copy link
Contributor Author

Manually tested. The test infrastructure is broken when merging to anything but master. I'm merging as-is.

@joejulian joejulian merged commit 8da312b into testing Jun 3, 2020
@joejulian joejulian deleted the backport/273/testing branch June 3, 2020 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants