Add a version check gulp task to default #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poltergeist
force-pushed
the
feature/version-check
branch
from
d4d7df0
to
5f08af2
Compare
Merged
Poltergeist
force-pushed
the
feature/version-check
branch
from
5f08af2
to
5b757aa
Compare
| @@ -225,10 +225,25 @@ gulp.task("replace-js-strings", ["webpack", "minify-js"], function () { | |||
| .pipe(gulp.dest(dirs.dist)); | |||
| }); | |||
|
|
|||
| gulp.task("version-check", function () { | |||
| var shrinkwrapVersion = require("./npm-shrinkwrap")["node-version"]; | |||
| var packageVersion = require("./package").engines.node; | |||
There was a problem hiding this comment.
The package.json is already required here:
https://github.com/mesosphere/marathon-ui/blob/feature/version-check/gulpfile.js#L17
|
Great idea! Really helpful. |
Poltergeist
force-pushed
the
feature/version-check
branch
from
f2d5ca7
to
783fb9d
Compare
|
⚡ |
aldipower
added a commit
that referenced
this pull request
Jan 21, 2016
Add a version check gulp task to default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@philipnrmn and I added a version check to gulp to prevent version divergence. This ensures that npm-shrinkwrap does not get corrupted by different versions of node.