Feature - 3240: Add volumes tab to application page #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poltergeist
force-pushed
the
feature/volumes-tab
branch
6 times, most recently
from
121740c
to
6727b81
Compare
|
This is a great feature! Cool! |
Poltergeist
force-pushed
the
feature/volumes-tab
branch
from
38cf38c
to
1a36467
Compare
| "dropup": !state.sortDescending | ||
| }); | ||
|
|
||
| var idClassSet = classNames({ |
There was a problem hiding this comment.
This and the following lines have a lot of repetition.
Could you condense this into something reusable?
Similar to this.getCaret() maybe?
|
Thank you so much for taking care of this. |
added 10 commits
March 4, 2016 16:04
This cloeses mesosphere/marathon#3240
Now the volumes are filled with real data from the app.tasks. volumes now have a detail view.
- onAppReuestError - onDeleteAppSuccess Remove unused code
added 15 commits
March 4, 2016 16:05
This will be shown in the volume detail view. Remove volume ID from list.
Poltergeist
force-pushed
the
feature/volumes-tab
branch
2 times, most recently
from
0f90cbe
to
058a4c4
Compare
Poltergeist
force-pushed
the
feature/volumes-tab
branch
from
f829ed5
to
e7b9e17
Compare
|
@aldipower I added the suggestions you commented on the code in the first go. Thank you for taking time reviewing this PR. |
| return null; | ||
| } | ||
|
|
||
| return volumes.reduce((memo, volume) => { |
There was a problem hiding this comment.
Wouldn't a reverse .find() do the job more descriptive?
|
Looks beautiful! Hallelujah! |
aldipower
added a commit
that referenced
this pull request
Mar 4, 2016
Feature - 3240: Add volumes tab to application page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new tab to the application page which shows details about the volumes associated with the application. For now this are only the configured volumes. This has been builded with the volumes at the tasks in mind.
This tab is only shown if there are any Volumes configured with the application.
This introduces a Volume tab at the Task details which has the same capabilities like the application page tab.
This introduces a detail view for a volume which has some information on the volumes as links to the parent task and application.
This Introduces tooltips in the create and edit modal to show the user some information on local volumes.
This introduces a warning when the user tries to scale down an application which has a volume associated with it.
This adds a work around to add a resident app if a volume is associated with it.
This closes mesosphere/marathon#3240