-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - 3240: Add volumes tab to application page #647
Conversation
121740c
to
6727b81
Compare
This is a great feature! Cool! |
38cf38c
to
1a36467
Compare
"dropup": !state.sortDescending | ||
}); | ||
|
||
var idClassSet = classNames({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the following lines have a lot of repetition.
Could you condense this into something reusable?
Similar to this.getCaret()
maybe?
Thank you so much for taking care of this. |
This cloeses mesosphere/marathon#3240
Now the volumes are filled with real data from the app.tasks. volumes now have a detail view.
- onAppReuestError - onDeleteAppSuccess Remove unused code
This will be shown in the volume detail view. Remove volume ID from list.
0f90cbe
to
058a4c4
Compare
f829ed5
to
e7b9e17
Compare
@aldipower I added the suggestions you commented on the code in the first go. Thank you for taking time reviewing this PR. |
return null; | ||
} | ||
|
||
return volumes.reduce((memo, volume) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't a reverse .find()
do the job more descriptive?
Looks beautiful! Hallelujah! |
Feature - 3240: Add volumes tab to application page
This introduces a new tab to the application page which shows details about the volumes associated with the application. For now this are only the configured volumes. This has been builded with the volumes at the tasks in mind.
This tab is only shown if there are any Volumes configured with the application.
This introduces a Volume tab at the Task details which has the same capabilities like the application page tab.
This introduces a detail view for a volume which has some information on the volumes as links to the parent task and application.
This Introduces tooltips in the create and edit modal to show the user some information on local volumes.
This introduces a warning when the user tries to scale down an application which has a volume associated with it.
This adds a work around to add a resident app if a volume is associated with it.
This closes mesosphere/marathon#3240