Add link to volumes to docker settings #660
Conversation
|
👍 Mainly for any existing users who are confused about where the settings have went. |
| @@ -27,10 +28,16 @@ var CollapsiblePanelComponent = React.createClass({ | |||
| this.setState({ | |||
| isOpen: nextProps.isOpen | |||
| }); | |||
| if (this.props.togglePanel != null) { | |||
| this.props.togglePanel(false); | |||
| } | |||
There was a problem hiding this comment.
Small thing, but the presence of this test seems rather unidiomatic to me - I'd prefer props.togglePanel to be required or no-op by default.
|
Would be nice to have a gif/screenshot for UI changes in PRs ;) |
| isOpen={ | ||
| this.fieldsHaveError({volumes: "volumes"}) || | ||
| state.isVolumesOpen | ||
| } |
There was a problem hiding this comment.
Can we extract this rather than having it all inline? Also I'd prefer to avoid the OR if possible. I think both of these are in our style guide.
|
Not sure I like the wording |
|
You are right probably |
|
@Poltergeist the problem is |
|
^^ Agreed. Configure is a nicer verb - we could also have |
|
|
|
Sorry for the multiple rounds of review, I didn't test manually the first time and got bitten by the omission. Having done so, I see a couple of issues
|
|
cc @leemunroe |
Poltergeist
force-pushed
the
feature/link-volumes-from-docker
branch
from
a44afce
to
54eba54
Compare
Add link to volumes to docker settings
This adds a link from the docker section to the volumes section. This may be removed at a later time. @leemunroe thought it would be a good idea to have this for usability purposes.