Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused InstanceTracker method #4941

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Remove unused InstanceTracker method #4941

merged 1 commit into from
Feb 13, 2017

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jan 12, 2017

Releates to: #3031

@mesosphere-ci
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@mesosphere-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@janisz janisz force-pushed the async/instance_tracker/remove_method branch from 749dfdd to 5993d22 Compare January 23, 2017 15:46
aquamatthias
aquamatthias approved these changes Jan 24, 2017
View reviewed changes
Copy link
Contributor

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janisz janisz force-pushed the async/instance_tracker/remove_method branch from 5993d22 to 3d40498 Compare January 30, 2017 13:32
@janisz
Copy link
Contributor Author

janisz commented Jan 30, 2017

Rebased

@aquamatthias
Copy link
Contributor

test this please

@aquamatthias
Copy link
Contributor

@janisz sorry we were not fast enough. Can you resolve the conflict?

@janisz
Copy link
Contributor Author

janisz commented Feb 9, 2017

No problem. I'll do it next week.

@janisz janisz force-pushed the async/instance_tracker/remove_method branch from 3d40498 to cafd9e9 Compare February 11, 2017 20:30
@janisz
Copy link
Contributor Author

janisz commented Feb 11, 2017

@aquamatthias Rebased

@aquamatthias
Copy link
Contributor

ok to test

@aquamatthias aquamatthias merged commit 423bb45 into mesosphere:master Feb 13, 2017
@aquamatthias
Copy link
Contributor

Thanks!

@janisz janisz deleted the async/instance_tracker/remove_method branch February 13, 2017 12:09
@jeschkies jeschkies mentioned this pull request Feb 16, 2017
Closed
1 task
@marcomonaco marcomonaco added the pr label Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquamatthias aquamatthias aquamatthias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@janisz @mesosphere-ci @aquamatthias @marcomonaco