Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix voice call flow deserialization and other unrelated clean-up #66

Merged

Conversation

codefrenzy
Copy link
Contributor

@codefrenzy codefrenzy commented Dec 4, 2019

This pull request includes a few changes:

  • Changed the target framework for the MessageBird project back down to .net framework 4.0 and netstandard2.0. This allows the solution to build on Mac.
  • Changed the return type of create, update and view methods for voice call flows to return the same as the Java SDK does (a data array with a links object). Added more assertions to unit tests to verify properties are deserialized properly. Changed the namespaces to the default one for all the unit tests.
  • Renaming existing namespace MessageBird.Objects.VoiceCalls to MessageBird.Objects.Voice and MessageBird.Resources.VoiceCalls to MessageBird.Resources.Voice so that we can put all other Voice API related objects and resources into these namespaces together.
  • Also renaming existing VoiceCallFlow classes to CallFlow, to mimic the PHP SDK and eventually allow us to split the MessageBird client into separate clients per API.

Annie Vella added 3 commits December 4, 2019 11:20
…etstandard2.0. This allows the solution to build on Mac.
…call flows to return the same as the Java SDK does (a data array with a links object). Added more assertions to unit tests to verify properties are deserialized properly. Changed the namespaces to the default one for all the unit tests.
…Bird.Objects.Voice and MessageBird.Resources.VoiceCalls to MessageBird.Resources.Voice so that we can put all other Voice API related objects and resources into these namespaces together
@codefrenzy codefrenzy changed the title Fix voice call flow deserialization and some unrelated clean-up Fix voice call flow deserialization and other unrelated clean-up Dec 4, 2019
@epels epels merged commit 114428b into messagebird:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants