Replace Base64.java
with the JDK-provided Base64
decoder
#242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #241, I spotted a TODO to replace
Base64.java
with something else. While it appears there are plans for wider changes (deletingRequestSigner
entirely?), I have not engaged with those because I don't fully understand the context for those changes.That said: I don't think there's any reason to wait for a major, breaking release to retire
Base64.java
, and I also don't think there's any reason to pull in a new library. The MessageBird Java SDK already targets Java 8, which provides its own base64 encoder/decoder. There's also exactly one (internal!) usage of the base64 decoding in the MessageBird SDK, so I think it's completely safe to make this substitution even within a minor release.