Add support for fetching outbound SMS prices #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-signal
changed the title
jon-signal
force-pushed
the
sms_pricing
branch
from
54c172b
to
fd48147
Compare
jon-signal
force-pushed
the
sms_pricing
branch
from
fd48147
to
20a811d
Compare
|
Hi @jon-signal, thanks for creating the PR. I am going to review it. I saw the pricing API documentation is under "quickstarts" as you mention, but it would be totally fine to include that in the SDK. |
denizkilic
reviewed
Aug 17, 2023
|
LGTM. Merging it and I will create a new release. |
|
Thank you! I really appreciate the fast review/release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for getting outbound SMS prices from the MessageBird API as described in the Pricing API documentation. I notice that the documentation is technically under "quickstarts," but I was unable to locate more canonical documentation under "API reference." If there's a more appropriate set of documentation to link to, I'll happily adjust this pull request (and my own bookmarks)!