Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relaxes the default runtime treatment of
#
, and expands the meaning ofMessageFormat#setStrictNumberSign(true)
to return to the previous, stricter treatment.Before, we had this:
With this PR, we get this:
To get that to work, I needed to make the runtime depend on the MessageFormat class, which was easier to do by separating Runtime to be more clearly its own class, defined in
lib/runtime.js
.